Era support for nimbus import #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45ec773
to
2363e7a
Compare
tersec
reviewed
Jun 29, 2024
arnetheduck
reviewed
Jul 2, 2024
arnetheduck
reviewed
Jul 2, 2024
arnetheduck
reviewed
Jul 2, 2024
arnetheduck
reviewed
Jul 2, 2024
tersec
reviewed
Jul 3, 2024
tersec
reviewed
Jul 3, 2024
tersec
reviewed
Jul 3, 2024
tersec
reviewed
Jul 3, 2024
nimbus/nimbus_import.nim
Outdated
| when consensusFork >= ConsensusFork.Capella: | ||
| return ok((forkyState.data.historical_roots, forkyState.data.historical_summaries, slot+8192)) | ||
| else: | ||
| return ok((forkyState.data.historical_roots, HashList[HistoricalSummary, Limit HISTORICAL_ROOTS_LIMIT](), slot+8192)) |
There was a problem hiding this comment.
Era's 8192 slots per file is derived from various constants in the consensus specs, e.g., SLOTS_PER_HISTORICAL_ROOT, or SLOTS_PER_EPOCH * SHARD_COMMITTEE_PERIOD. Not sure if makes sense to re-derive these now that from this code's perspective, they're just what Era files do, but it's a bit of a magical constant at the moment.
There was a problem hiding this comment.
In my opinion doesn't make sense doing that for the import process
tersec
reviewed
Jul 3, 2024
tersec
reviewed
Jul 3, 2024
tersec
reviewed
Jul 3, 2024
tersec
reviewed
Jul 3, 2024
144d223
to
8fd48cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2306