Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluffy portal testnet support #2383

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Fluffy portal testnet support #2383

merged 4 commits into from
Jun 18, 2024

Conversation

web3-developer
Copy link
Contributor

@web3-developer web3-developer commented Jun 18, 2024 •
edited
Loading

Changes in this PR:

  • Bump portal-mainnet repo.
  • Now using angelfood testnet bootnodes from portal-mainnet repo when angelfood is selected as the network.
  • Updated Fluffy startup configuration parameters. Added new options and made the old options deprecated and hidden.
  • Added portal protocol ids for all networks and subnetworks as defined in the spec.
  • Minor updates to the Fluffy guide.

web3-developer
web3-developer commented Jun 18, 2024
View reviewed changes
fluffy/conf.nim
Network* = enum
beacon
history
state
Copy link
Contributor Author

@web3-developer web3-developer Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved into portal_protocol_config.nim because these types are needed by portal_protocol.nim

@web3-developer web3-developer mentioned this pull request Jun 18, 2024
Closed
kdeme
kdeme approved these changes Jun 18, 2024
View reviewed changes
fluffy/fluffy.nim
let
# Portal works only over mainnet data currently
# TODO: investigate this load network data function
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for loading beacon network metadata , so this remains the same for angelfood.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks, I'll remove the comment in my next PR.

@web3-developer web3-developer merged commit e3d14bd into master Jun 18, 2024
15 checks passed
@web3-developer web3-developer deleted the fluffy-portal-testnet-support branch June 18, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdeme kdeme kdeme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@web3-developer @kdeme