Implement Fluffy JSON-RPC endpoints. #2364
Merged
+129
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd eth_getCode JSON-RPCs.
web3-developer
changed the title
kdeme
approved these changes
Jun 14, 2024
| raise newException(ValueError, error) | ||
|
|
||
| balance = (await stateNetwork.get().getBalance(blockHash, data.EthAddress)).valueOr: | ||
| # Should we return 0 here or throw a more detailed error? |
There was a problem hiding this comment.
If I understand it right, there are many errors that can occur here and it would be difficult to be certain that the account simply doesn't exist (and thus return 0).
There was a problem hiding this comment.
Yeah that was my thought as well.
| nonce = ( | ||
| await stateNetwork.get().getTransactionCount(blockHash, data.EthAddress) | ||
| ).valueOr: | ||
| # Should we return 0 here or throw a more detailed error? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON-RPC endpoints implemented:
Tests will be added in a future PR.