Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nim-eth, nim-web3, nimbus-eth2 #2344

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Bump nim-eth, nim-web3, nimbus-eth2 #2344

merged 8 commits into from
Jun 14, 2024

Conversation

jangko
Copy link
Contributor

@jangko jangko commented Jun 13, 2024

This PR may looks massive, but actually it only deals with:

  • Replace std.Option with results.Opt from nim-web3, but because it affected a lot of areas, then I decide to replace all Option usage.
  • Fields name changes from nim-eth
  • BlockNumber from UInt256 to uint64

While the GasInt conversion to uint64 have been cancelled because it is too complex on its own.

Fluffy failing CI is related to #2343

@jangko
Copy link
Contributor Author

jangko commented Jun 14, 2024

Looks like no more conflicts between commits and base branch.

@jangko jangko merged commit 5a18537 into master Jun 14, 2024
26 checks passed
@jangko jangko deleted the gasint-blocknumber branch June 14, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants