Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vendor RocksDb dll on Windows. #2341

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Use vendor RocksDb dll on Windows. #2341

merged 3 commits into from
Jun 13, 2024

Conversation

web3-developer
Copy link
Contributor

@web3-developer web3-developer commented Jun 12, 2024 •
edited
Loading

This PR includes the following changes:

  • Bump nim-rocksdb to latest version
  • Update Makefile to build RocksDb DLL from vendor directory on Windows. No longer using fetched DLLs.
  • Update Windows section of readme.

@web3-developer web3-developer merged commit 060c759 into master Jun 13, 2024
10 checks passed
@web3-developer web3-developer deleted the windows-use-built-rocksdb-dll branch June 13, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnetheduck arnetheduck Awaiting requested review from arnetheduck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@web3-developer