Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Fluffy to support hive tests. #2333

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

web3-developer
Copy link
Contributor

@web3-developer web3-developer commented Jun 10, 2024

This PR includes the following changes:

  • Updated the fluffy-with-portal-hive page of the Fluffy book to align with the updates steps to run hive for portal.
  • Add an optional and hidden parameter to Fluffy to support disabling validation of state content against a state root. This is required for now because the portal hive tests don't support setting up history network with block headers data.
  • Updated the portal_stateStore JSON-RPC endpoint so that it will decode content values which are expected to be in the form of a offer. It then converts the offer to an lookup value (without the proof) before storing. No other validations are done here because this is only receiving the data locally and storing locally. Not part of the usual offer flow.

@web3-developer web3-developer changed the title Updates to Fluffy book for hive tests. Updates to Fluffy to support hive tests. Jun 11, 2024
@web3-developer web3-developer marked this pull request as ready for review June 11, 2024 05:33
@web3-developer
Copy link
Contributor Author

web3-developer commented Jun 11, 2024

All the hive state tests are now passing locally after making these changes. I've run Fluffy in isolation as well as Fluffy with Trin.

@web3-developer web3-developer merged commit 9c26fa3 into master Jun 11, 2024
11 checks passed
@web3-developer web3-developer deleted the fluffy-fixes-for-hive-tests branch June 11, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants