Implementation of procs to support Fluffy state JSON-RPC endpoints. #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web3-developer
changed the title
web3-developer
commented
Jun 10, 2024
| n: HistoryNetwork, bn: UInt256 | ||
| ): Future[Result[Opt[Block], string]] {.async.} = | ||
| let | ||
| blockHash = ?(await n.getBlockHashByNumber(bn)) |
There was a problem hiding this comment.
@kdeme Please let me know if this update to the history network looks ok.
kdeme
approved these changes
Jun 10, 2024
| n: HistoryNetwork, bn: UInt256 | ||
| ): Future[Result[Opt[Block], string]] {.async.} = | ||
| let | ||
| blockHash = ?(await n.getBlockHashByNumber(bn)) |
fluffy/rpc/rpc_eth_api.nim
Outdated
| @@ -139,7 +139,7 @@ proc installEthApiHandlers*( | |||
|
|
|||
| rpcServerWithProxy.registerProxyMethod("eth_feeHistory") | |||
|
|
|||
| rpcServerWithProxy.registerProxyMethod("eth_getBalance") | |||
| # rpcServerWithProxy.registerProxyMethod("eth_getBalance") | |||
There was a problem hiding this comment.
Not really a big deal, as I don't think anybody uses/tests it in that way, but I wanted to note that currently with these registerProxyMethods enabled you can let the requests be forwarded to another endpoint until implemented.
There was a problem hiding this comment.
Good point. I'm planning to implement these endpoints shortly but I'll revert this part just to prevent any issues in the mean time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.