Cleanup stateless and block witness code. #2295
Conversation
…which is used in the eth_getProofsByBlockNumber RPC endpoint which is needed for the Fluffy state network bridge.
…what the flag does. We only collect the keys of the touched accounts and storage slots but no block witness generation is supported for now.
|
|
||
| let | ||
| chain = newChain(com, extraValidation = true, ctx.vmState) |
There was a problem hiding this comment.
@arnetheduck I noticed that this vmState parameter was removed from the newChain procs in one of your recent changes. Was this intentional?
I had to remove the parameter to get the code to compile but this test may now be broken once we get the Aristo db working.
There was a problem hiding this comment.
ah - I missed that it was used somewhere - probably because these files were not enabled - it can be added back if it's useful, it was cleaned up just to simplify things
There was a problem hiding this comment.
Ok, I'll add it back in
web3-developer
changed the title
|
@arnetheduck now that @mjfh has merged in his recent changes and approved this PR, can you confirm if this change is something we want to do? |
|
A backup of the stateless code is in this branch for future reference: https://github.com/status-im/nimbus-eth1/tree/stateless-backup |
can you create an issue with the functionality disabled by this PR, linking to it there? |
Sure. Done, see here: #2327 |
This PR cleans up all the experimental stateless code and anything related to block witnesses. Note that this doesn't clean up anything related to eth_getProof as it doesn't use the block witness format.
Keeping MultiKeys which is used in the eth_getProofsByBlockNumber RPC endpoint which is needed for the Fluffy state network bridge.