rm Clique consensus method support and Goerli network #2219
Conversation
| @@ -93,7 +91,7 @@ proc newEngineEnv*(conf: var NimbusConf, chainFile: string, enableAuth: bool): E | |||
| chain = newChain(com) | |||
|
|
|||
| com.initializeEmptyDb() | |||
| let txPool = TxPoolRef.new(com, conf.engineSigner) | |||
| let txPool = TxPoolRef.new(com, ZERO_ADDRESS) | |||
There was a problem hiding this comment.
can we get rid of this last arg?
There was a problem hiding this comment.
Sure, as a follow-up PR.
There was a problem hiding this comment.
In particular, it appears, after POW has been removed more thoroughly, because this miner variable is also used for that purpose, and some tests still therefore refer to it. This requires more care than POA, because currently it appears to start in POW in several instances, then transition to POS almost, but not quite, immediately on startup.
It might be cleaner to address POW first, but ultimately, either ordering works, as long as there's not an expectation that POW mode produces blocks with non-zero miners in the meantime, which should be fine insofar as it doesn't seem important it produces block at all at this point.
Regarding Goerli, https://blog.ethereum.org/2023/11/30/goerli-lts-update and status-im/nimbus-eth2#6057