Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trivial memory-based speedups #2205

Merged
merged 2 commits into from
May 23, 2024
Merged

trivial memory-based speedups #2205

merged 2 commits into from
May 23, 2024

Conversation

arnetheduck
Copy link
Member

  • HashKey becomes non-ref
  • use openArray instead of seq in lots of places
  • avoid sequtils.reversed when unnecessary
  • add basic perf stats to test_coredb

@arnetheduck
trivial memory-based speedups
1796311 
* HashKey becomes non-ref
* use openArray instead of seq in lots of places
* avoid sequtils.reversed when unnecessary
* add basic perf stats to test_coredb
@arnetheduck
copyright
0fb2745
@arnetheduck
Copy link
Member Author

arnetheduck commented May 22, 2024 •
edited
Loading

fwiw, this represents ~40% time savings on (early) block import

@mjfh
Copy link
Contributor

mjfh commented May 23, 2024

fwiw, this represents ~40% time savings on (early) block import
cool

@arnetheduck arnetheduck merged commit f38c5e6 into master May 23, 2024
27 checks passed
@arnetheduck arnetheduck deleted the simple-speedups branch May 23, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arnetheduck @mjfh