Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for disallowed transaction superseding #2181

Merged
merged 3 commits into from
May 28, 2024

Conversation

etan-status
Copy link
Contributor

The transaction spammer from Kurtosis keeps spamming transactions with the same nonce because report 'pending' account nocne based on 'latest' rather than actually considering the mempool. To avoid errors from rejecting those, disable the required gas price bump when replacing a transaction with a new nonce.

The transaction spammer from Kurtosis keeps spamming transactions with
the same nonce because report 'pending' account nocne based on 'latest'
rather than actually considering the mempool. To avoid errors from
rejecting those, disable the required gas price bump when replacing
a transaction with a new nonce.
@tersec
Copy link
Contributor

tersec commented May 27, 2024

Is this strictly a workaround for Kurtosis behavior which should probably be fixed, or does it point to a nimbus-eth1 issue? If the former, seems like something the Kurtosis panda ops people should address

@etan-status
Copy link
Contributor Author

It's both. The root cause are other workarounds because we don't implement estimate gas for 'pending' correctly. Which then triggers followup issue in the tx spammer that now runs into superseding case which it normally doesn't hit. Goal was to get nimbus-eth1 into a minimally testable state, while breaking the least.

@jangko
Copy link
Contributor

jangko commented May 28, 2024

This will be merged, but a note is added to #2094

@jangko jangko merged commit 741fcca into master May 28, 2024
7 checks passed
@jangko jangko deleted the dev/etan/tx-superseding branch May 28, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants