Add retrieval content validation to state network. #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web3-developer
commented
May 6, 2024
| # at your option. This file may not be copied, modified, or distributed except according to those terms. | ||
|
|
||
| import eth/common, ./state_content | ||
|
|
There was a problem hiding this comment.
Is there anything else to validate after retrieving a state value apart from checking that the value returned matches the expected hash contained in the key?
There was a problem hiding this comment.
For the retrieval part, no, I don't think so
web3-developer
commented
May 6, 2024
| check: | ||
| validateAccountTrieNodeHash( | ||
| contentKey.accountTrieNodeKey, contentValueRetrieval | ||
| ) == false |
There was a problem hiding this comment.
More tests are being added. Currently in progress.
kdeme
approved these changes
May 6, 2024
| # at your option. This file may not be copied, modified, or distributed except according to those terms. | ||
|
|
||
| import eth/common, ./state_content | ||
|
|
There was a problem hiding this comment.
For the retrieval part, no, I don't think so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.