Premix persist tool improvements #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o com.db.compensateLegacySetup().
web3-developer
commented
Feb 1, 2024
| TOOLS_DIRS := \ | ||
| tests | ||
| tests \ | ||
| premix |
There was a problem hiding this comment.
Added this so we can build the tool as a separate binary with: make persist
web3-developer
commented
Feb 1, 2024
| vmState.generateWitness = true # Enable saving witness data | ||
| vmState.com.hardForkTransition(blockHeader) |
There was a problem hiding this comment.
Fixing a bug found during my recent testing. Without this the miner rewards may not be correct during processBlock.
web3-developer
commented
Feb 1, 2024
| sleep(1000) | ||
| continue | ||
| else: | ||
| raise e |
There was a problem hiding this comment.
Added support for retrying the request for block data so that the tool doesn't crash due to temporary network issues.
kdeme
reviewed
Feb 1, 2024
premix/persist.nim
Outdated
| thisBlock = requestBlock(blockNumber, { DownloadAndValidate }) | ||
| except CatchableError as e: | ||
| if retryCount < 3: | ||
| warn "Unable to block data via JSON-RPC API", error = e.msg |
There was a problem hiding this comment.
Suggested change
| warn "Unable to block data via JSON-RPC API", error = e.msg | |
| warn "Unable to get block data via JSON-RPC API", error = e.msg |
jangko
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.