Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable POKE for fluffy tests by default (#1640) #1711

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

mynameisdaniil
Copy link
Contributor

No description provided.

Copy link
Contributor

@kdeme kdeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this works, I was thinking of rather making it into a runtime option.

This will especially be useful for portal-hive testing (the main reason we need it, although in our own testing we could also have tests that require POKE to be turned on or off).
The reason for this is that portal-hive uses our Fluffy docker image, available on docker hub, and else we need to build a second version for this, which I wouldn't recommend.

So instead I think it could be a runtime option, probably a hidden cli option, which could be added to the portal config, and a new disablePoke field in the PortalProtocol. wdyt?

Makefile Outdated Show resolved Hide resolved
@mynameisdaniil mynameisdaniil force-pushed the turn-off-poke-1640 branch 3 times, most recently from 58a2243 to c7e8258 Compare August 29, 2023 02:52
@mynameisdaniil
Copy link
Contributor Author

@kdeme pls take a look again. More like this?

fluffy/conf.nim Outdated Show resolved Hide resolved
fluffy/conf.nim Outdated Show resolved Hide resolved
fluffy/conf.nim Outdated Show resolved Hide resolved
@mynameisdaniil
Copy link
Contributor Author

@kdeme I've addressed the issues you've mentioned. Please take one more look.

@kdeme kdeme merged commit 85134eb into master Aug 30, 2023
8 checks passed
@kdeme kdeme deleted the turn-off-poke-1640 branch August 30, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants