Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified database frontend #1661

Merged
merged 8 commits into from
Jul 31, 2023
Merged

Unified database frontend #1661

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e4049e1
Remove 32bit os support from `custom_network` unit test
mjfh Jul 24, 2023
9a25ac2
Hide unused sources do not compile
mjfh Jul 26, 2023
6521ce7
Re-implemented `db_chain` as `core_db`
mjfh Jul 24, 2023
435ec57
Support compiler exception warnings for CoreDbRef base methods.
mjfh Jul 31, 2023
bd289b0
Allow `pairs()` iterator on all memory based key-value tables
mjfh Jul 31, 2023
abfaf9d
Merge branch 'master' into Unified-database-frontend
mjfh Jul 31, 2023
acfefef
Backport `chain_db.nim` changes into its re-implementation `core_apps…
mjfh Jul 31, 2023
526d6ec
Fix exception annotation
mjfh Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Support compiler exception warnings for CoreDbRef base methods.
  • Loading branch information
@mjfh
mjfh committed Jul 31, 2023
commit 435ec57b057e866ce47a14b167530d8e05809808
15 changes: 15 additions & 0 deletions nimbus/db/core_db/base.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ proc init*(db: CoreDbCaptRef; parent: CoreDbRef; flags: set[CoreDbCaptFlags]) =
# ------------------------------------------------------------------------------

proc dbType*(db: CoreDbRef): CoreDbType =
db.kvt.dbType

proc dbType*(db: CoreDbKvtRef): CoreDbType =
db.dbType

proc kvt*(db: CoreDbRef): CoreDbKvtRef =
Expand Down Expand Up @@ -231,6 +234,8 @@ method mptPrune*(

# -----

{.push hint[XCannotRaiseY]: off.}

method get*(
db: CoreDbMptRef;
key: openArray[byte];
Expand Down Expand Up @@ -265,6 +270,8 @@ method contains*(
{.base, raises: [RlpError].} =
db.parent.notImplemented "contains/mpt"

{.pop.}

method rootHash*(
db: CoreDbMptRef;
): Hash256
Expand Down Expand Up @@ -330,6 +337,8 @@ method phkPrune*(

# -----------

{.push hint[XCannotRaiseY]: off.}

method get*(
db: CoreDbPhkRef;
key: openArray[byte];
Expand Down Expand Up @@ -364,6 +373,8 @@ method contains*(
{.base, raises: [RlpError].} =
db.parent.notImplemented "contains/phk"

{.pop.}

method rootHash*(
db: CoreDbPhkRef;
): Hash256
Expand Down Expand Up @@ -395,13 +406,17 @@ method dispose*(t: CoreDbTxRef) {.base.} =
method safeDispose*(t: CoreDbTxRef) {.base.} =
t.parent.notImplemented "safeDispose"

{.push hint[XCannotRaiseY]: off.}

method shortTimeReadOnly*(
db: CoreDbRef;
id: CoreDbTxID;
action: proc() {.gcsafe, raises: [CatchableError].};
) {.base, raises: [CatchableError].} =
db.notImplemented "shortTimeReadOnly"

{.pop.}

# ------------------------------------------------------------------------------
# End
# ------------------------------------------------------------------------------