Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateless mode (not yet working!!!) #1570

Closed
wants to merge 5 commits into from

Conversation

AdamSpitz
Copy link
Contributor

@AdamSpitz AdamSpitz commented Apr 28, 2023

Here's a branch containing the (unfinished!) code for stateless mode.

When I tried merging this in a week ago, it caused a performance regression (see #1558), so I reverted it. I'm pushing this branch so that someone else can (if you want to) pick up this code after I'm gone, but I'm not merging it into master (so I'm expecting the bits to rot if nobody does this soon).

(Note that the performance regression has nothing to do with running in stateless mode; this code causes a performance regression even when running normally.)

Regarding the cause of the performance regression, I'd suggest looking at memory.nim (where I had to switch to using a seq[Future[byte]] instead of a seq[byte]); there's probably some clever data structure you could use instead, but it'll need to involve Futures in some way in order to allow opcodes like MLOAD and MSTORE to play nicely with speculative execution. Note that I'm not saying that I know for sure that memory.nim is the cause of the problem, just that it's one place in the code where I did something obviously-hideously-inefficient, so that'd be a good first place to look.

The work on speculative execution isn't finished; see the comment on popInt in stack.nim, explaining how to finish propagating the async-stack-pop through the rest of the code base.

The work on stateless-execution in general isn't finished, but the idea is to pass in an Ethereum JSON-RPC URL for the stateless-data-source-url parameter on the command line. The intent is that this should make the Engine API (see handle_newPayload in engine_api.nim) run new blocks statelessly. But like I said, this work isn't finished; in the past (see #1311) I had blocks almost running correctly-but-very-slowly (it took five minutes to run a block, and often ran into that problem described in the comment at repeatedlyTryToPersist in process_transaction.nim, and I never quite got the peer pool correctly downloading those missing nodes), but this branch is an imperfect recreation of that past branch and I haven't managed to finish it before I leave.

I'm sorry for leaving the code in such a lousy state. Good luck!

@AdamSpitz AdamSpitz self-assigned this Apr 28, 2023
@tersec
Copy link
Contributor

tersec commented Jun 5, 2024

Closing but leaving branch pending investigation for it it contains potentially useful code.

@tersec tersec closed this Jun 5, 2024
@arnetheduck arnetheduck deleted the stateless-mode-not-yet-working branch October 27, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants