Bump Nim to 1.6 and resolve the related issues #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeme
commented
Jan 23, 2023
| try: | ||
| ac.trie.get(address) | ||
| except RlpError: | ||
| raiseAssert("No RlpError should occur on trie access for an address") |
There was a problem hiding this comment.
Not fully sure if this assumption is correct
kdeme
commented
Jan 23, 2023
| flags: {IsAlive} | ||
| ) | ||
| except RlpError: | ||
| raiseAssert("No RlpError should occur on decoding account from trie") |
kdeme
force-pushed
the
nim-1.6
branch
4 times, most recently
from
0f3a359
to
7ab9e69
Compare
Two unresolved items currently: - Three tests that are temporarily disabled as they fail in the macro_assembler code, which seems to be due to an ambigious identifier Stop (Ops and chronos ServerCommand enum). - i386 CI disabled as it fails at Nim compilation already. Failed tests where already ignored for this target.
|
Will go ahead and merge this, the macro_assembler will be fixed later so that those 3 tests can be run again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raises[Defect]toraises[], but not doing this in this PR yet.