-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time based forking #1434
Closed
Closed
Time based forking #1434
Commits on Jan 16, 2023
-
Timestamp-based hard forks, starting with Shanghai
Replaced the ForkToBlockNumber array with a (more complicated) object called ForkTransitionTable that knows the difference between block-based forks, time-based forks, and the special cases like MergeFork and Shanghai (which IIUC needs to be doable via either block number or time, at least temporarily). Created a type called ForkDeterminationInfo to represent the information needed to determine which hard fork a particular block is on. In the past all we needed was a block number; now we need to pass in both a block number and timestamp (and if mergeForkBlock isn't specified, maybe TD as well), so I created a type for it (though I don't love the name). Several things are still unresolved. (See various places that say FIXME-Adam.) But I think this is progress.
Configuration menu - View commit details
-
Copy full SHA for 7205d57 - Browse repository at this point
Copy the full SHA 7205d57View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2af973 - Browse repository at this point
Copy the full SHA c2af973View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc20c1a - Browse repository at this point
Copy the full SHA bc20c1aView commit details
Commits on Jan 21, 2023
-
Refactoring: extracted the engine API handler bodies into procs.
Intending to implement the V2 versions next. (I need the bodies to be in separate procs so that multiple versions can use them.)
Configuration menu - View commit details
-
Copy full SHA for 58c6899 - Browse repository at this point
Copy the full SHA 58c6899View commit details -
Configuration menu - View commit details
-
Copy full SHA for af531f1 - Browse repository at this point
Copy the full SHA af531f1View commit details
Commits on Jan 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4b599cd - Browse repository at this point
Copy the full SHA 4b599cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for d379e26 - Browse repository at this point
Copy the full SHA d379e26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6025b0e - Browse repository at this point
Copy the full SHA 6025b0eView commit details -
Removed the no-longer-used blockToFork table.
(We only use the new forkTransitionTable now.)
Configuration menu - View commit details
-
Copy full SHA for 250a403 - Browse repository at this point
Copy the full SHA 250a403View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3868d9 - Browse repository at this point
Copy the full SHA b3868d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 121cf31 - Browse repository at this point
Copy the full SHA 121cf31View commit details
Commits on Jan 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 40b78bf - Browse repository at this point
Copy the full SHA 40b78bfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.