Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time based forking #1434

Closed
wants to merge 12 commits into from
Closed

Time based forking #1434

wants to merge 12 commits into from

Commits on Jan 16, 2023

  1. Timestamp-based hard forks, starting with Shanghai

    Replaced the ForkToBlockNumber array with a (more complicated) object called ForkTransitionTable that knows the difference between block-based forks, time-based forks, and the special cases like MergeFork and Shanghai (which IIUC needs to be doable via either block number or time, at least temporarily).
    
    Created a type called ForkDeterminationInfo to represent the information needed to determine which hard fork a particular block is on. In the past all we needed was a block number; now we need to pass in both a block number and timestamp (and if mergeForkBlock isn't specified, maybe TD as well), so I created a type for it (though I don't love the name).
    
    Several things are still unresolved. (See various places that say FIXME-Adam.) But I think this is progress.
    AdamSpitz committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    7205d57 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c2af973 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bc20c1a View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2023

  1. Refactoring: extracted the engine API handler bodies into procs.

    Intending to implement the V2 versions next. (I need the bodies to be
    in separate procs so that multiple versions can use them.)
    AdamSpitz committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    58c6899 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    af531f1 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. attempt to make ci green

    jangko committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    4b599cd View commit details
    Browse the repository at this point in the history
  2. Merged.

    AdamSpitz committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    d379e26 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6025b0e View commit details
    Browse the repository at this point in the history
  4. Removed the no-longer-used blockToFork table.

    (We only use the new forkTransitionTable now.)
    AdamSpitz committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    250a403 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b3868d9 View commit details
    Browse the repository at this point in the history
  6. Bumped nim-stew.

    AdamSpitz committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    121cf31 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Configuration menu
    Copy the full SHA
    40b78bf View commit details
    Browse the repository at this point in the history