Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump nim-eth for withdrawalsRoot support #1326

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

etan-status
Copy link
Contributor

The BlockHeader structure in nim-eth was updated with support for EIP-4895 (withdrawals). To enable the nim-eth bump, the ingress of BlockHeader structures has been hardened to reject headers that have the new withdrawalsRoot field until proper withdrawals support exists. status-im/nim-eth#562

The `BlockHeader` structure in `nim-eth` was updated with support for
EIP-4895 (withdrawals). To enable the `nim-eth` bump, the ingress of
`BlockHeader` structures has been hardened to reject headers that have
the new `withdrawalsRoot` field until proper withdrawals support exists.
status-im/nim-eth#562
@etan-status
Copy link
Contributor Author

Hardened at these locations:

  • p2p validate
  • fast sync
  • fluffy history network

Did I miss another one?

Copy link
Contributor

@kdeme kdeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you got all.

Seemed like a lot of changes but turns out the test output files haven't been updated since last test updates.

@etan-status etan-status merged commit bc3f164 into master Nov 26, 2022
@etan-status etan-status deleted the dev/etan/sf-shanghaiheader branch November 26, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants