Use queries with custom xor function #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeme
approved these changes
Jun 3, 2022
fluffy/content_db.nim
Outdated
Comment on lines
215
to
216
| fraction > 0 and fraction < 1, | ||
| "Deleted fraction shohould be > 0 and < 1" |
There was a problem hiding this comment.
Suggested change
| fraction > 0 and fraction < 1, | |
| "Deleted fraction shohould be > 0 and < 1" | |
| fraction > 0 and fraction < 1, | |
| "Deleted fraction should be > 0 and < 1" |
| var bytesDeleted: int64 = 0 | ||
| let targetBytes = target.toByteArrayBE() | ||
| for e in db.getAllOrderedByDistanceStmt.exec(targetBytes, ri): | ||
| if bytesDeleted + ri.payloadLength < bytesToDelete: |
There was a problem hiding this comment.
It doesn't matter that much in our current setting, as an arbitrary fraction is chosen anyhow, but it would be more correct if you still allow the last deletion to reach the amount of bytesToDelete (or slightly more).
There was a problem hiding this comment.
I think it is matter of preference i.e current approach interprets fraction as at most data to delete, where with allowing this last deletion it would be at least data to delete. I slightly prefer at most interpretation as it allows to discard case when the whole database could be deleted when someone would provide fraction of 0.99 (or something similar)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes custom logic to sort elements, by using custom xor function on sqlite level and sql query to sort results by xor distance.
Next step is to add nice queries to get content in range of node radius like:
"SELECT key WHERE xorDistance(?, key) <= radius LIMIT limit"