Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--customnetwork:FILE.json does not work with test network Calaveras using the official file #786

Closed
jlokier opened this issue Aug 5, 2021 · 1 comment · Fixed by #787
Labels
Config Command line or config file related

Comments

@jlokier
Copy link
Contributor

jlokier commented Aug 5, 2021

Using this option --customnetwork:calaveras.json with or without --networkid:123 fails to result in a successful connection ot the Calaveras network, because genesis hash, network Id and probably other values are incorrect.

The file calaveras.json is the JSON file in the Calaveras specification.

In network logs some things are clear:

  • The networkId we are using is zero. It should be 123. This is visible in the eth.Status message, but it's a missing value in the chain config, not the network code.
  • The genesis hash we are using is wrong. It should be eb9233d066c275efcdfed8037f4fc082770176aefdbcb7691c71da412a5670f2 but we have calculated 2893a852a2fdec70cfb74307512489a2880c55703dcb623e3cf51300474af8d4 after setting up the genesis config.
  • We have poaEngine: false, but this is a PoA network, and is configured as such in the JSON file.

Do we not support this file format?

@jlokier jlokier added the Config Command line or config file related label Aug 5, 2021
@jangko
Copy link
Contributor

jangko commented Aug 5, 2021

  • networkId can be set from --networkId:123
  • the json file need to be modified a bit. all genesis fields should be put into genesis:
{
 "config": { 
   ...
},
 "genesis": {  #  <-  move all genesis fields into here
  ... 
}      
}
  • configure PoA using json file/command line is not supported yet.

jangko added a commit that referenced this issue Aug 5, 2021
- allow clique period and epoch to be configured via config file
- this also activate poaEngine mode
- remove clique period configuration from cli to reduce confusion
- fix #786
jangko added a commit that referenced this issue Aug 5, 2021
- allow clique period and epoch to be configured via config file
- this also activate poaEngine mode
- remove clique period configuration from cli to reduce confusion
- fix #786
jangko added a commit that referenced this issue Aug 5, 2021
- allow clique period and epoch to be configured via config file
- this also activate poaEngine mode
- remove clique period configuration from cli to reduce confusion
- fix #786
@jangko jangko closed this as completed in c69e57e Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config Command line or config file related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants