Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hive: devp2p/eth: implement missing handler of eth protocol #673

Closed
jangko opened this issue May 20, 2021 · 2 comments · Fixed by #1300
Closed

hive: devp2p/eth: implement missing handler of eth protocol #673

jangko opened this issue May 20, 2021 · 2 comments · Fixed by #1300
Labels
Hive Sync Prevents or affects sync with Ethereum network

Comments

@jangko
Copy link
Contributor

jangko commented May 20, 2021

many of the handlers of eth protocol both in nim-eth and nimbus-eth1 are still empty or maybe buggy.
we need to implement them to pass devp2p/eth tests in hive
@jangko jangko added the Hive label May 20, 2021
@jlokier
Copy link
Contributor

jlokier commented Jul 1, 2021

Can you expand on this a bit? Which parts of the eth protocol does Hive exercise, and which versions?

@jlokier jlokier added the Sync Prevents or affects sync with Ethereum network label Jul 1, 2021
@jangko
Copy link
Contributor Author

jangko commented Jul 2, 2021

hive will relay the test to https://github.com/ethereum/go-ethereum/tree/master/cmd/devp2p/internal/ethtest

from brief glance it looks like ethtest try to connect using eth/66 first then fallback to eth/65 or eth/64.

some of protocol methods used by ethtest are:

  • Status
  • GetBlockHeaders
  • NewBlock
  • NewBlockHashes
  • NewPooledTransactionHashes?
  • GetBlockBodies
  • GetPooledTransactions
  • Transactions

not tested methods:

  • GetNodeData
  • GetReceipts

jangko added a commit that referenced this issue Nov 15, 2022
@jangko
eth wire protocol: implement NewBlock and NewBlockHashes handler
c7c821a 
and it also do invasive changes to fast sync because
they are tightly related.

fix #673
jangko added a commit that referenced this issue Nov 16, 2022
@jangko
eth wire protocol: implement NewBlock and NewBlockHashes handler
34281db 
and it also do invasive changes to fast sync because
they are tightly related.

fix #673
@jangko jangko mentioned this issue Nov 16, 2022
Merged
jangko added a commit that referenced this issue Nov 16, 2022
@jangko
eth wire protocol: implement NewBlock and NewBlockHashes handler
d40a2b3 
and it also do invasive changes to fast sync because
they are tightly related.

fix #673
@jangko jangko closed this as completed in fffe071 Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hive Sync Prevents or affects sync with Ethereum network
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

eth wire protocol: implement NewBlock and NewBlockHashes handler status-im/nimbus-eth1
2 participants
@jangko @jlokier