-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hive: ethereum/consensus: need to port header validation code #666
Labels
Comments
mjfh
added a commit
that referenced
this issue
May 18, 2021
Merged
mjfh
added a commit
that referenced
this issue
May 24, 2021
after #668, failing test cases reduced again from 59 to 44. nimbus-eth1/tests/test_blockchain_json.nim Line 262 in 2539bd9
|
#726 further reduce failing test cases down to 10 (Berlin, without London) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
the number of failing cases in
ethereum/consensus
test suite dwindling to 59.one case (bcHomesteadToEIP150/EIP150Transition_HomesteadToEIP150At5) identified to be caused by a subtle bug in
mapper.jq
file. (#667)but majority of them related to block header validation.
sub category such as
bcTotalDifficultyTest
andbcInvalidHeaderTest
clearly indicate we need to port those validation codefrom
test_blockchain_json
back to nimbus.related procs in
test_blockchain_json
:bcMultiChainTest
sub category also passtest_blockchain_json
, I suspect we also need to port some code back to nimbus but not sure which part.after the ported code is stable enough, we can remove those in
test_blockchain_json
The text was updated successfully, but these errors were encountered: