-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boolean opcodes do not compile on latest devel #63
Labels
Comments
This will be addressed in 67476a1 |
mratsim
pushed a commit
that referenced
this issue
Jul 5, 2018
Merge note: currently cannot compile due to `quasiBoolean` (#63). This will be solved by #65 ---- * Implemented most of the stubbed out state handling instructions The code compiles, but still fails at the moment due to incorrect initialization of the VM. Don't merge yet. More commits will be pushed in the coming days. * Fixed crash * trie put and del are void now * getBlockTransactionData and getReceipts * Working code for extcodesize0.json * fix origin.json * fix calldatasize1 * fix calldataloadSizeTooHighPartial * fix calldataloadSizeTooHigh * more efficient PushX implementation * fix and, or, xor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current boolean implementation relies on
0 == false
in a corner macro case that was fixed in devel.Consequently, Nimbus does not compile on latest devel
https://github.com/status-im/nimbus/blob/6f28d1186675f648e0587f44e730b9dc23291bab/nimbus/vm/interpreter/opcodes_impl/helpers.nim#L13-L39
The text was updated successfully, but these errors were encountered: