Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't reconnect to staticnodes after connection failure or disconnect #618

Closed
jlokier opened this issue May 3, 2021 · 0 comments · Fixed by #1205
Closed

Doesn't reconnect to staticnodes after connection failure or disconnect #618

jlokier opened this issue May 3, 2021 · 0 comments · Fixed by #1205
Labels
Sync Prevents or affects sync with Ethereum network

Comments

@jlokier
Copy link
Contributor

jlokier commented May 3, 2021

The --staticnodes options is most useful for nodes that are willing to provide service. But occasionally, Geth doesn't accept a connection even if we are "trusted node" for Geth. It's just luck; the Geth would be willing, but at that moment it didn't have capacity.

Currently, after a connection failure or disconnect, Nimbus-eth1 stays disconnected from its --staticnodes.
When this hapens, Nimbus-eth1 should reconnect after a short time, on the assumption that's what --staticnodes is for.

This is especially important when we aren't syncing to anything else and have discovery turned off, and in that state Nimbus-eth1 becomes kind of useless, reporting zero peers in a loop.

@jlokier jlokier added the Sync Prevents or affects sync with Ethereum network label Jul 1, 2021
@jangko jangko closed this as completed in c6f3514 Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sync Prevents or affects sync with Ethereum network
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant