-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove code duplication from test_blockchain_json #592
Comments
jangko
added a commit
that referenced
this issue
May 14, 2021
now test_blockchain_json is using block validation code from p2p/executor.nim instead of using it's own block validation code. this will reduce maintenance cost and fixes #592.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
current situation:
test_blockchain_json.nim
have it's own code for block validation, and nimbus has it's own code for block validation. The reason is, in the past nimbus block validation is a mess, sotest_blockchain_json
was developed in parallel as a debugging tool too and some of the code is ported back to nimbus or code from nimbus copied totest_blockchain_json
.why it is bad:
The text was updated successfully, but these errors were encountered: