Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confusion between chainId and networkId in nimbus-eth1 code #558

Closed
jangko opened this issue Feb 11, 2021 · 0 comments
Closed

confusion between chainId and networkId in nimbus-eth1 code #558

jangko opened this issue Feb 11, 2021 · 0 comments

Comments

@jangko
Copy link
Contributor

jangko commented Feb 11, 2021

Coincidentally, the networkId and chainId of mainnet and some of built in testnets have identical value.
This lead to misuse/mix use of them in many places and not detected by any test. They also use ordinary integer without clear distinction to prevent incorrect assignment from chainId to networkId and vice versa.

Some functions/parameter also misnomer in this area that lead to other developers(e.g. me) to believe they are the same entity but actually different.

My experiment with EIP2930 reveal this issue should be fixed before EIP2718 and EIP2930 are implemented.

Furthermore, this issue will add more confusion for the upcoming EIP2364, EIP2464, and EIP2481.

see also https://medium.com/@pedrouid/chainid-vs-networkid-how-do-they-differ-on-ethereum-eec2ed41635b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant