Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all_tests bug, failure at subtest not bubble up to caller process #404

Closed
jangko opened this issue Oct 16, 2019 · 5 comments
Closed

all_tests bug, failure at subtest not bubble up to caller process #404

jangko opened this issue Oct 16, 2019 · 5 comments

Comments

@jangko
Copy link
Contributor

jangko commented Oct 16, 2019

for example, the appveyor 32 bit have failures but the CI report it as green because the failure masked by all_tests bug.

@stefantalpalaru
Copy link
Contributor

Got a CI log link for this?

@jangko
Copy link
Contributor Author

jangko commented Oct 16, 2019

here is the link

@stefantalpalaru
Copy link
Contributor

OK. I remember fixing something similar in the past. Some variables in unittest macros where hidden by the use of wrapper functions in other custom macros.

@jangko
Copy link
Contributor Author

jangko commented Oct 16, 2019

the problem is actually simple. all_tests only need to read exit code from sub test process and use it as it's own exit code.

jangko added a commit to jangko/nimbus-eth1 that referenced this issue Oct 16, 2019
jangko added a commit to jangko/nimbus-eth1 that referenced this issue Oct 16, 2019
jangko added a commit to jangko/nimbus-eth1 that referenced this issue Oct 17, 2019
jangko added a commit that referenced this issue Oct 17, 2019
@jangko
Copy link
Contributor Author

jangko commented Oct 17, 2019

fixed by #405, closing

@jangko jangko closed this as completed Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants