Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

^(int, int): Uint256 overloading is surprising and conflicts with stdlib #39

Closed
mratsim opened this issue May 24, 2018 · 0 comments
Closed

^(int, int): Uint256 overloading is surprising and conflicts with stdlib #39

mratsim opened this issue May 24, 2018 · 0 comments

Comments

@mratsim
Copy link
Contributor

mratsim commented May 24, 2018

https://github.com/status-im/nimbus/blob/502941a388b6110adaab9697f9a375e0dc598eda/src/constants.nim#L49-L55

This is in conflict with Nim math standard lib and only saves a few characters in constants.nim. (i.e. 2 ^ 256 instead of 2.u256 ^ 256)
@mratsim mratsim mentioned this issue May 24, 2018
Merged
mratsim added a commit that referenced this issue May 25, 2018
@mratsim
Gas & Memory ops refactoring - uses native integer instead of uint256 f…
cb49352 
…ixes #35 and #39 (#40)

* Gas refactoring - uses int64

* Use primitive int in test_vm_json
@mratsim mratsim closed this as completed May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mratsim