Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instrumentation] Replace logging "framework" by nim-chronicles #38

Closed
mratsim opened this issue May 24, 2018 · 0 comments
Closed

[Instrumentation] Replace logging "framework" by nim-chronicles #38

mratsim opened this issue May 24, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@mratsim
Copy link
Contributor

mratsim commented May 24, 2018

Current:

Future:
@mratsim mratsim added the enhancement New feature or request label May 24, 2018
arnetheduck added a commit that referenced this issue Aug 23, 2018
@arnetheduck
replace logging module with nim-chronicles (see #38)
273ea85 
This blindly changes logging to nim-chronicles - issues that ensue:

* absurd amounts of logs in gas computation, slows down tests by orders
of magnitude (lacking trace level) - the problem is further exacerbated
by chronicles' default multi-line output
* unclear if logScope is practical - for example, since vm is split over
many files, topics get lost when using simple top-level per-module
topics
* when passing named object around, scope should incliude the name of
the object but this is caught neither by logScope nor by dynamicLogScope
arnetheduck added a commit that referenced this issue Aug 31, 2018
@arnetheduck
Merge pull request #117 from status-im/logging-to-chronicles
1d49b65 
replace logging module with nim-chronicles (fixes #38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mratsim