-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
block 1.352.922 doesn't have a test case #363
Comments
kdeme
added a commit
that referenced
this issue
Aug 14, 2019
kdeme
added a commit
that referenced
this issue
Aug 14, 2019
jangko
added a commit
that referenced
this issue
Aug 15, 2019
Add PersistBlockTest for block 1352922, fixes #363
fixed by #375, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR #357 doesn't include a test case. In the past, the problematic code already fixed numerous times. Probably because of premature optimization while the code was written first time.
Better to have a test case to prevent further regression. To generate a test case, a database contains information about the block should available. Then use
persistBlockTestGen
tool in foldertests/
to generate a json test case.The text was updated successfully, but these errors were encountered: