-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack/MessageOptions not converting hex integers to Uint256 #32
Labels
bug
Something isn't working
Comments
MessageOptions was basically just a typed version of the optional py-evm args being passed to newMessage, it's not a meaningful type otherwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The message option type is not converting hex string to Uint256:
https://github.com/status-im/nimbus/blob/43797485e5c50d94fef5a4b9afba858632190896/src/vm/message.nim#L42-L48
This leads to several test failures
https://github.com/status-im/nimbus/blob/43797485e5c50d94fef5a4b9afba858632190896/tests/fixtures/VMTests/vmTests/boolean.json#L17-L26
I didn't find any mention of MessageOptions type in Py-EVM, Go-Ethereum, Parity codebases even in past commits besides Go Protobuf.
The text was updated successfully, but these errors were encountered: