Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_all no longer being executed in CI #239

Closed
stefantalpalaru opened this issue Feb 21, 2019 · 1 comment
Closed

test_all no longer being executed in CI #239

stefantalpalaru opened this issue Feb 21, 2019 · 1 comment

Comments

@stefantalpalaru
Copy link
Contributor

We can't have multiple "test()" invocations in "nimbus.nimble" because of how setCommand() works. When test "test_rpc" was added after test "test_all" it replaced it completely. You can see the result here: https://travis-ci.org/status-im/nimbus/jobs/496386459

I fixed this problem in the "submodules" branch by replacing setCommand() with exec(): #231

GitHub's interface doesn't let me assign this issue to @jangko, so I'll use a mention instead. Ideally, we'd figure out why "test_all.nim" was crashing when "test_rpc" was included. In the mean time, not running "test_rpc" is better than not running "test_all".

@jangko
Copy link
Contributor

jangko commented Feb 22, 2019

aha, that's why the CI test pass so quickly.
I'll push emergency fix at my next PR

jangko added a commit to jangko/nimbus-eth1 that referenced this issue Feb 23, 2019
@zah zah closed this as completed in 1bc8f41 Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants