-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The routing_table_nodes metric format is wrong #1528
Comments
This might have to do with the fact that we use the same routing_table code for discv5 and each different Portal sub-network. Aside from the weird double metric, the metric itself will also be incorrect as it will hold the data for all networks together. We should find a way to split this |
Hah, I forgot about this. It would be nice to fix this, but for now I'll just drop this metric:
|
Actually, it appears this issue also exists in Nim-Waku nodes:
So I've dropped those too:
And opened an issue: |
Is anyone going to fix it at any point? Hello? |
My initially quick assessment at #1528 (comment) was not the actually cause for this (although that work should still be done). The cause is some import/export pollution of the discv4 routing table code. And although this code is not actually used, it has the same metric name (without the label). Quickfix for now is to rename that one, see status-im/nim-eth#646 |
Fix in #1874 |
Thank you. |
It appears the last instance of this error in Prometheus for
And the graph does show this too: Which also matches with the build timer run on
So I consider this fixed. Thank you @kdeme . |
I have been seeing some errors on the metrics backend that started on the 17th of March:
Those errors are
duplicate sample for timestamp
and always are triggered for therouting_table_nodes
metric:If we look at the metric itself it appears to be broken:
As we can see it's listed twice. Once with
state
label, which has""
and"seen"
values, but also as a metric without any labels.This looks like a bug that was introduces somewhere around 17th of March.
The text was updated successfully, but these errors were encountered: