Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_blockchain_json should check lastBlockHash after a test cycle completed. #1338

Closed
jangko opened this issue Nov 29, 2022 · 0 comments · Fixed by #1361
Closed

test_blockchain_json should check lastBlockHash after a test cycle completed. #1338

jangko opened this issue Nov 29, 2022 · 0 comments · Fixed by #1361
Labels
bug Something isn't working tests

Comments

@jangko
Copy link
Contributor

jangko commented Nov 29, 2022

In json test fixtures of blockchain test, lastBlockHash field is the head block hash of last succesfully executed block.
Test_blockchain_json currently does not make any attempt to check it.
The result is, when executing POS blocks, it happily pass all tests but actually never know that the canonical head never moved forward.

related to #1337, maybe need #1323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix persistHeaderToDb, allow POS block header to be canonical status-im/nimbus-eth1
1 participant
@jangko