Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

importRlpBlock doesn't move canonical head forward when importing POS blocks #1337

Closed
jangko opened this issue Nov 29, 2022 · 0 comments · Fixed by #1361
Closed

importRlpBlock doesn't move canonical head forward when importing POS blocks #1337

jangko opened this issue Nov 29, 2022 · 0 comments · Fixed by #1361
Labels
bug Something isn't working Hive

Comments

@jangko
Copy link
Contributor

jangko commented Nov 29, 2022 •
edited
Loading

Test cases in hive/eth/consensus simulator requires last successfully imported block appears when queried by rpc/eth_getBlockByHash.

It works well for pre merge blocks, but not so for POS blocks. Maybe this should be fixed in persistBlocks rather than in importRlpBlock.

maybe need #1323

note: consensus_sim in hive_integration currently skip merge fork test cases. reenable them when this issue fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Hive
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix persistHeaderToDb, allow POS block header to be canonical status-im/nimbus-eth1
1 participant
@jangko