Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement getBlockBody #126

Closed
coffeepots opened this issue Aug 30, 2018 · 1 comment
Closed

Implement getBlockBody #126

coffeepots opened this issue Aug 30, 2018 · 1 comment

Comments

@coffeepots
Copy link
Contributor

coffeepots commented Aug 30, 2018 •
edited
Loading

Implementation required for getBlockBody.
This routine fetches the BlockBody from the Chain by it's hash.

There are currently two version to satisfy (there is also an AbstractChainDb version that should remain as raising an error):

  • method getBlockBody*(c: Chain, blockHash: KeccakHash): BlockBodyRef in nimbus\p2p\chain.nim
  • proc getBlockBody*(self: BaseChainDB, h: Hash256, output: var BlockBody): bool in nimbus\db\db_chain
@coffeepots coffeepots changed the title Implement getBlockHeader Implement getBlockBody Aug 30, 2018
@coffeepots coffeepots mentioned this issue Nov 19, 2018
Open
@coffeepots
Copy link
Contributor Author

Implemented by #181

jangko added a commit that referenced this issue Jan 17, 2024
@jangko
Bump nim-web3 to ce47cde31c9b08e4b702766d4d788cc83fa55cf0
2c25ca3 
Synchronize order of blobGasUsed / excessBlobGas in test (#126)
jangko added a commit that referenced this issue Jan 17, 2024
@jangko
Bump nim-web3 to ce47cde31c9b08e4b702766d4d788cc83fa55cf0
1d50d03 
Synchronize order of blobGasUsed / excessBlobGas in test (#126)
@jangko jangko mentioned this issue Jan 17, 2024
Merged
jangko added a commit that referenced this issue Jan 17, 2024
@jangko
Bump nim-web3 to ce47cde31c9b08e4b702766d4d788cc83fa55cf0
ae82d56 
Synchronize order of blobGasUsed / excessBlobGas in test (#126)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coffeepots