txpool: where those missing transactions go?

[jangko]

using the same setup as test_txpool2, below code failed.
the recipient, amount and sender of those transaction are identical. they only differ in the tx nonce. but looks like some of the transaction cannot reach destination block.

var
    env = initEnv(some(100.u256))
    xp = env.xp
    chainDB = env.chainDB
    chain = env.chain
    head = chainDB.getCanonicalHead()
    timestamp = head.timestamp

  const
    txPerblock = 20
    numBlocks = 10

  for n in 0..<numBlocks:
    for tn in 0..<txPerblock:
      let tx = env.makeTx(recipient, amount)
      let res = xp.addLocal(tx, force = true)
      if res.isErr:
        debugEcho res.error
        return

    xp.jobCommit()
    xp.prevRandao = prevRandao
    var blk = xp.ethBlock()
    doAssert chain.isBlockAfterTtd(blk.header)

    timestamp = timestamp + 1.seconds
    blk.header.difficulty = DifficultyInt.zero
    blk.header.prevRandao = prevRandao
    blk.header.nonce = default(BlockNonce)
    blk.header.extraData = @[]
    blk.header.timestamp = timestamp

    let body = BlockBody(
       transactions: blk.txs,
       uncles: blk.uncles
    )

    let rr = chain.persistBlocks([blk.header], [body])
    doAssert rr == ValidationResult.OK

    # PoS block canonical head must be explicitly set using setHead
    chainDB.setHead(blk.header)

    discard xp.jobDeltaTxsHead(blk.header)
    xp.head = blk.header
    xp.jobCommit()

  doAssert chainDB.currentBlock == 10.toBlockNumber
  head = chainDB.getBlockHeader(chainDB.currentBlock)
  var sdb = newAccountStateDB(chainDB.db, head.stateRoot, pruneTrie = false)
  let expectedBalance = u256(txPerblock * numBlocks) * amount
  let balance = sdb.getBalance(recipient)
  debugEcho "BALANCE: ", balance
  debugEcho "EXPECTED: ", expectedBalance
  doAssert balance == expectedBalance

expected output:

BALANCE: 200000
EXPECTED: 200000

current output:

BALANCE: 180000
EXPECTED: 200000

something wrong in the test code, or txPool misuse?

[jangko]

log show something like this but I don't know if this is related or not

DBG 2022-04-04 08:17:07.142+07:00 invalid tx: account nonce mismatch
  tid: 4052
  file: validate.nim:320
  txNonce: 0
  accountNonce: 20

[mjfh]

The code above is all right.

There was typo in the function jobDeltaTxsHead(), see #1034