effectiveGasTip in txPool different from gasTip in processTransactionImpl

[jangko]

Using steps below(some code omitted for clarity):

let tx = makeTx(recipient, amount)

xp.addLocal(tx, force = true)
xp.jobCommit()

var blk = xp.ethBlock()
let body = BlockBody(
  transactions: blk.txs,
  uncles: blk.uncles
)

clique.prepare(parent, blk.header)
clique.seal(blk)

chain.persistBlocks([blk.header], [body])

nimbus-eth1/nimbus/utils/tx_pool/tx_tasks/tx_packer.nim

Line 105 in 6a90937

gasTip = item.tx.effectiveGasTip(xp.chain.head.baseFee)

nimbus-eth1/nimbus/p2p/executor/process_transaction.nim

Line 99 in 6a90937

vmState.stateDB.addBalance(miner, gasBurned.u256 * priorityFee.u256)

Both gasTip and baseFee in tx_packer.nim are different from priorityFee and baseFee in process_transaction.nim. Because of that, stateRoot produced by txPool is not equal to the one produced by persistBlocks.

This issue reveals, probably we need to lift EIP1559 tx normalization up higher near tx entry point to txPool.
Also need to harmonize between two different baseFee.

nimbus-eth1/nimbus/utils/tx_pool/tx_item.nim

Line 160 in 6a90937

proc effectiveGasTip*(tx: Transaction; baseFee: GasPrice): GasPriceEx =

Also in effectiveGasTip, for just one transaction, there are 3 different baseFee

BASEFEE: 875000000
gasPrice: 30000000000

BASEFEE: 1000000000
gasPrice: 30000000000

BASEFEE: 0
gasPrice: 30000000000