-
Notifications
You must be signed in to change notification settings - Fork 106
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
use statically linked rocksdb on linux/mac, dll on windows (#2291)
The `rocksdb` version shipped with distributions is typically old and therefore often lacks features we use - it also doesn't match the one assumed by nim-rocksdb leading to ABI mismatch risks. Instead of depending on the system rocksdb, we'll now use the rocksdb version assumed by nim-rocksdb and locked in its vendor folder by always building it together with nimbus. This avoids the problem of unknown rocksdb versions at a (small) cost to build time. CI caching and full windows support for building from source [remains TODO](status-im/nim-rocksdb#44).
- Loading branch information
1 parent
69a1588
commit 95a4adc
Showing
8 changed files
with
26 additions
and
76 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule nim-rocksdb
updated
12 files
+1 −1 | .github/workflows/ci.yml | |
+3 −0 | config.nims | |
+4 −0 | rocksdb/columnfamily/cfopts.nim | |
+5 −5 | rocksdb/lib/librocksdb.nim | |
+16 −0 | rocksdb/options/cache.nim | |
+45 −8 | rocksdb/options/dbopts.nim | |
+47 −0 | rocksdb/options/tableopts.nim | |
+1 −1 | rocksdb/rocksdb.nim | |
+3 −3 | scripts/build_static_deps.sh | |
+1 −1 | tests/lib/test_librocksdb.nim | |
+1 −1 | tests/test_columnfamily.nim | |
+3 −3 | tests/test_rocksdb.nim |
Submodule nimbus-build-system
updated
9 files
+2 −2 | .github/workflows/ci.yml | |
+0 −10 | .gitmodules | |
+7 −7 | makefiles/targets.mk | |
+19 −13 | scripts/build_nim.sh | |
+7 −5 | scripts/create_nbs_paths.sh | |
+2 −2 | scripts/env.sh | |
+1 −1 | vendor/Nim | |
+0 −1 | vendor/Nim-csources-v1 | |
+0 −1 | vendor/nimble |