Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote to make a community private or public #693

Conversation

cheny0
Copy link
Contributor

@cheny0 cheny0 commented Jul 12, 2023

  • First draft
  • Final draft
  • Minor fix

@cheny0 cheny0 added doc-new Additions to the Status documentation E:Communities Status Communities labels Jul 12, 2023
@cheny0 cheny0 requested a review from osmaczko July 12, 2023 05:40
@cheny0 cheny0 self-assigned this Jul 12, 2023
@cheny0
Copy link
Contributor Author

cheny0 commented Jul 12, 2023

Hi Patryk @osmaczko, this document introduces the procedure of voting to add / remove a community from the directory.

@cheny0 cheny0 requested a review from jorge-campo August 1, 2023 09:12
@cheny0
Copy link
Contributor Author

cheny0 commented Aug 4, 2023

@jorge-campo, the article for switching networks using Status Wallet doesn't exist yet. When it's ready I'll add a link to this document and #698.

Copy link
Contributor

@jorge-campo jorge-campo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Chen, thanks for your content.

Because this article is similar to the 'Vote to feature a Status Community' (PR #698) one, I will only add here two comments relevant to this article.

Please, apply my comments in #698 (review) to this as well.

  • I'd start the article by saying, 'Status Communities can be public or private'. Your intro is a bit... abrupt :)
  • 'Whether a community is public or private is determined by a vote, open to all SNT holders, not just community members or Status users.' Please, change this sentence using the active voice. For example, 'A voting process determines ... All SNT holders... can participate on...'

Thanks.

@cheny0 cheny0 force-pushed the 676-add-or-remove-a-community-from-the-community-directory branch from dc95384 to 407d337 Compare August 13, 2023 11:59
@cheny0
Copy link
Contributor Author

cheny0 commented Aug 14, 2023

Hi Chen, thanks for your content.

Because this article is similar to the 'Vote to feature a Status Community' (PR #698) one, I will only add here two comments relevant to this article.

Please, apply my comments in #698 (review) to this as well.

* I'd start the article by saying, 'Status Communities can be public or private'. Your intro is a bit... abrupt :)

* 'Whether a community is public or private is determined by a vote, open to all SNT holders, not just community members or Status users.' Please, change this sentence using the active voice. For example, 'A voting process determines ... All SNT holders... can participate on...'

Thanks.

Hi @jorge-campo, I have applied your comments as we discussed over the call. Thanks!

@cheny0 cheny0 closed this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-new Additions to the Status documentation E:Communities Status Communities
Projects
Status: Published/Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants