Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watch-only accounts to your Status Wallet #689

Closed
wants to merge 3 commits into from

Conversation

earakel
Copy link
Contributor

@earakel earakel commented Jul 5, 2023

No description provided.

@earakel earakel self-assigned this Jul 5, 2023
@earakel earakel added doc-new Additions to the Status documentation E:Wallet Status Wallet labels Jul 5, 2023
@earakel earakel requested a review from jorge-campo July 5, 2023 21:22
Copy link
Contributor

@jorge-campo jorge-campo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @shamisem – Please, find my review comments inline.

Additionally:

  • Title should be 'Add watch-only accounts to your Status Wallet' As it is now, it's too unspecific.
  • Update the Miro board with the updated name, the GitHub issue ID, and the GitHub link. Miro is our source of truth; we should keep it tidy and up to date.
  • Can I keep track of NFTs in watch-only accounts? If we can, we should mention that.
  • Similarly to the 'Import an account' topic (see review here), you're missing the bold typeface in 'Origin' and 'Import in' in both procedures.

docs/en/status-wallet/add-watch-only-accounts.md Outdated Show resolved Hide resolved
docs/en/status-wallet/add-watch-only-accounts.md Outdated Show resolved Hide resolved
@earakel earakel changed the title Add watch-only accounts Add watch-only accounts to your Status Wallet Jul 21, 2023
@earakel
Copy link
Contributor Author

earakel commented Jul 21, 2023

@jorge-campo thanks for your review! All done.

The article is now ready for the new website.

@earakel earakel closed this Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-new Additions to the Status documentation E:Wallet Status Wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants