Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

640 Reset your notification settings #682

Closed
wants to merge 5 commits into from

Conversation

Fabiomorais87
Copy link
Contributor

Hi @jorge-campo,

In accordance with our agreement, I am sending the PR after we have completed the two steps.

1 - Meet with Jorge to determine if the article provides the user with all the information they need.

2 - Worked with Emma to polish the English.

I would appreciate any suggestions you have. :)

Fabio

@Fabiomorais87 Fabiomorais87 added doc-new Additions to the Status documentation E:ProfileSettings Status profile and settings labels Jul 3, 2023
@Fabiomorais87 Fabiomorais87 self-assigned this Jul 3, 2023
Copy link
Contributor

@jorge-campo jorge-campo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this content, @Fabiomorais87 – Here are just some minor changes I propose you to include:

  • Intro. We can simplify the wording a bit. I used WordTune for this. Same number of words, but the wording is easier: 'If you set custom notification settings before, but you don't receive the notifications you expect anymore, you can reset your settings. Doing so removes any exceptions, and the notification settings return to their default values.'
  • Procedure – You're missing the last step, where the user confirms they want to reset the notifications. Whenever you do these types of 'danger' actions (reset, delete, clear, etc.), it's almost certain you need to confirm the action. See this Figma file.

@jorge-campo
Copy link
Contributor

Hi @Fabiomorais87 , what's the status of this? Could you let me know if you implemented the review comments? Thanks.

@Fabiomorais87
Copy link
Contributor Author

This article has already been reviewed by campo and the content is good for publication. I already sent it to .mdx syntax review here https://github.com/status-im/status-website/pull/586. Waiting for the pr to be approved and then merge the content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-new Additions to the Status documentation E:ProfileSettings Status profile and settings
Projects
Status: Published/Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants