-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add or remove a nickname from someone else's profile #650
Conversation
Hi, @jorge-campo. Here are my review comments: IntroYour first paragraph introduces the idea of nicknames and what the user can gain from them. The concept of the nickname and the benefit behind it is a great one, but maybe it could put on a more conversational tone. I thought about few things to improve it a bit. I think it would be good to use the Cambridge dictionary idea (definition) about nicknames: "an informal name for someone or something, especially a name that you are called by your friends or family, usally based on your real name or you character" That said maybe we could change the paragraph to something like this:
If you would like to keep the same paragraph (as the original), maybe would be good to just change a few things. Here are two suggestions on how to restructure the paragraph:
Add a nickname to someone's profileMobileFirst step - "1.Open the channel or chat with the person you want to add a nickname to" In regards to this first step, when I first read the first step, I questioned if I could assign a nickname to someone I don't know or haven't added to my contacts. Since this is possible, I suggest mentioning this in the article, perhaps as an admonition, to keep channel on the step. Apart from that, do you mean "group chat" by chat? If so, I think we should use "group chat" instead of "chat". So in my opinion the first step should be like this: "1.Open the channel or group chat with the person you want to add a nickname to" Second step - "1. Long press the person's name and select :mobile-edit: Add nickname." In my opinion this second step should change to:
Third step - "1. Enter your desired nickname and tap Save." For the third step, I suggest changing "Save" to "Add nickname". This is because this is what the button on the figma file is called. ![]() According to the changes I mentioned for the H2, the final version of this procedure should be as follows:
Desktop**First step ** - "1. Open the channel or chat with the person you want to add a nickname to." In regards to this first step, when I first read the first step, I questioned if I could assign a nickname to someone I don't know or haven't added to my contacts. Since this is possible, I suggest mentioning this in the article, perhaps as an admonition, to keep channel on the step. Apart from that, do you mean "group chat" by chat? If so, I think we should use "group chat" instead of "chat". So in my opinion the first step should be like this: "1.Open the channel or group chat with the person you want to add a nickname to" Remove a nickname from someone's profileMobileFirst step - "1. Open the channel or chat with the person you want to remove the nickname from." So in my opinion the first step should be like this: "1.Open the channel or group chat with the person you want to add a nickname to" Second step - "Long press the person's name and select :mobile-delete: Remove nickname." In my opinion this second step should change to:
DesktopFirst Step - "1. Open the channel or chat with the person you want to remove the nickname from." So in my opinion the first step should be like this: "1.Open the channel or group chat with the person you want to remove the nickname from" Third Step - "1. On the Nickname pop-up window, click :desktop-clear: Clear to remove the nickname." I couldn't replicate this step. The Figma files that I have access to I couldn't find this option, and in the app (release 0.12) do not match the description of the step. To remove a nickname I followed the same procedure to add and then I click on an "x" that appears next to the box where I write the nickname (I'm not posting a picture because when I try to take a screenshot, it does not appear this "x" that I am mentioning). May we check together this last procedure? Please, let me know what you think and if you agree with the suggestions. :) |
Thanks for your review, @Fabiomorais87 – Please, see my answers to your comments inline.
Thanks for your suggestion, Fabio. I believe the concept of 'nicknames' is well understood by our audience. Besides, this is supposed to be a quick and easy-to-do thing. Considering these, I believe it's better to move the user toward the action as soon as possible.
Good point! I included that information in the topic.
When you say "chat", it includes DMs and group chats. I updated the procedure, just in case this is not clear.
I think I wrote this procedure before we decided to avoid the "long press" action. Thanks for the heads-up; I've updated the procedures.
I followed the dark mode workflow, which uses "Save". This is an error, and it should say "Add nickname" instead. I have updated the procedure and notified the Design team.
I verified the procedure again on my Status desktop installation and it works as described. The only thing I realized is that right-click does the same thing as the standard click, so I removed the right-click action. |
Thanks for your, review @Fabiomorais87 ! |
Waiting to merge this content into the new Status Help. |
Hello @Fabiomorais87 - I'm sending this one for your review.
Thanks.