Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom tokens #590

Closed
wants to merge 2 commits into from
Closed

Add custom tokens #590

wants to merge 2 commits into from

Conversation

earakel
Copy link
Contributor

@earakel earakel commented Apr 27, 2023

Hey @jorge-campo, sending this for your review!

@earakel earakel self-assigned this Apr 27, 2023
@earakel earakel added the doc-new Additions to the Status documentation label Apr 27, 2023
@earakel earakel requested a review from jorge-campo May 3, 2023 13:38
@earakel earakel added the E:Wallet Status Wallet label May 3, 2023
Copy link
Contributor

@jorge-campo jorge-campo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed the next steps and changes during our call.

Let's clarify first the terminology and what we understand by "custom tokens". This way, we can approach the article's updates with a fresh and better understanding.

Thanks, @shamisem !

@earakel
Copy link
Contributor Author

earakel commented Jun 22, 2023

Thanks for your review Jorge! This branch is quite old, so I feel it would be easier to simply close it and create a new one than fix all of those merge conflicts. I will apply your comments and submit the new version.

@earakel earakel closed this Jun 22, 2023
@jorge-campo
Copy link
Contributor

Hi @shamisem – When you close a branch and start working on a different one, add a comment to keep track of this fact. See #663, as an example. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-new Additions to the Status documentation E:Wallet Status Wallet
Projects
Status: Published/Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants