-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Receive crypto #583
Receive crypto #583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @shamisem - Here is my review.
Your article's structure is atypical and doesn't follow the style guide structure for a procedure. However, I can understand the reason for that. On the one hand, placing the task at the end of the article won't work because there is plenty of content before. On the other hand, I see this content as a requirement. Therefore, let's consider this an exception without forgetting that, whenever possible, topics should adhere to the structure described in the style guide.
-
"(which starts with
0x
)". Good point. I find it useful to provide information on how to identify your public key. However, "0x" just means hexadecimal, and some wallets might include the "0x" prefix to indicate that the private key is in hexadecimal format, even though this is not a standard practice.
What do you think if, in addition to the prefix rule, we also discuss the key length rule? -> 64 characters for private keys and 42 characters, including the "0x" prefix, for public addresses. -
Mobile > Step 2: "From the navigation bar, tap..." -> "From the top navigation, tap..." (see style guide UI areas for mobile).
-
What do you think about the following two steps?
- Step 4. To copy your public address, click :desktop-copy: Copy address. Send the address to the sender.
- Step 5. Alternatively, ask the sender to scan your public address QR code with their crypto wallet.
- I include step 5 because we need to consider the case that sender and receiver are next to each other and, in this case, scanning the QR is the fastest (and generally more secure) way to share the address.
-
I repeat here the suggestions I was discussing in our group chat:
- Under "Your legacy and multichain addresses", when you mention "click Edit", I'd mention where this screen is. You say that in the preceding procedure, but it's nevertheless useful. This will force you to rephrase things so sentences are not too long.
- Many people (even people familiar with crypto) have never used these multichain addresses. Users may think, "If I share this multichain address, will the sender be able to use it?" Maybe it's good to explain that the sender wallet must also support multichain (?)
Thanks.
Hey @jorge-campo, thanks so much for your review now and for your suggestions earlier!
Sorry for not responding to your suggestions on Discord earlier - I wanted to do so after implementing them and then got stuck with the 'Your legacy and multichain addresses' section. |
No need to be sorry, @shamisem ! All good 👌 Awesome work on a topic that it's not particularly easy to explain to newcomers. I'm not a newcomer, and I also learned something new! 😄 |
Hey @jorge-campo!
This article will need a screenshot from Francesca, but otherwise it's ready for review.