Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understand your wallet balance #557

Closed
wants to merge 1 commit into from

Conversation

earakel
Copy link
Contributor

@earakel earakel commented Apr 11, 2023

Update: this article still needs a screenshot from Francesca, but otherwise it's ready for review.

@earakel earakel marked this pull request as draft April 11, 2023 18:37
@earakel earakel changed the title [draft] Understand your wallet balance Understand your wallet balance Apr 11, 2023
@earakel earakel self-assigned this Apr 11, 2023
@earakel earakel added doc-new Additions to the Status documentation E:Wallet Status Wallet labels Apr 11, 2023
@earakel earakel requested a review from jorge-campo May 3, 2023 13:41
@earakel earakel marked this pull request as ready for review May 3, 2023 13:42
Copy link
Contributor

@jorge-campo jorge-campo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your article, @shamisem !

We need to add some changes. Here is my review.

  • In your title, "Wallet" should use uppercase "W". Even when your article works for any wallet, we discuss the Status Wallet here, not just any wallet.
  • You're missing the link for this article at urls-en.txt. Please, check the article itself, the index.md entry, and the hamburger menu entry with the Material for MkDocs preview. Alternatively, push your article to develop to check for these.
  • There are more analogies to bank apps in crypto wallets than differences. Similarly to bank apps, your money is not on the app; it's on the bank. Everyone understands that if they uninstall the bank app, the money isn't gone, but many don't understand that if they uninstall the wallet app, crypto is not gone.

It would be easier for a crypto newcomer to have a bank app reference, even when crypto has little to do with banks. Instead of using the "bank app" example to tell users "we're not the same", why not use this example to welcome them with terms they are already familiar with? It's a better (and more welcoming) use of your example.

Note: (update Jun, 22.) After our conversation, we've decided that using the bank analogy for discussing how a crypto wallet works is not a good idea.

Besides, I find the "Crypto wallets aren't bank apps" sentence a bit discouraging/negative.

  • I would clarify what's "fiat". I've seen many newcomers asking this question in forums. Maybe you can do that right after talking about EUR/USD.

  • "To double-check...". I wouldn't write this. If we tell users they can "double-check" the balance we present them in their wallet, we're implicitly saying they can't fully trust Status Wallet. And this is not the case. What I would discuss in this section is the fact that the balance fluctuates because the relative crypto-fiat value fluctuates in the market.

  • "you didn't make", I would use "you don't recognize". Sometimes you make transactions you don't recognize or remember, but they are transactions you actually made.

  • You mentioned the missing screenshot, but you can add the information for that screenshot now. Think of your article with a screenshot like the one I attach, and explain what total balance (A), account balance (B), asset balance (C), and balance changes (D) are. For this, use a tabbed interface, like the one you can see at https://help.status.im/en/status-communities/channels-your-quick-start-guide/#__tabbed_1_1 (2)

balance


Screenshot 2023-05-05 at 9 37 14

This way, your article will be ready for the screenshot, and you simply need to include it once it's ready. Concept-type articles should be related as much as possible to the Status app. Try to use examples/screens from the app that helps the user to relate this content to our app.

I'm happy to review this offline with you if that helps.

Thank you.

@earakel
Copy link
Contributor Author

earakel commented Jun 22, 2023

Thanks for your review Jorge! This branch is quite old, so I feel it would be easier to simply close it and create a new one than fix all of those merge conflicts. I will apply your comments and submit the new version.

@earakel earakel closed this Jun 22, 2023
@jorge-campo
Copy link
Contributor

Superseded by https://github.com/status-im/status-website/issues/1022.

(hey @shamisem, when you replace a branch or PR with another one, add a closing comment like the one above. This helps to track things down when necessary. Thank you.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-new Additions to the Status documentation E:Wallet Status Wallet
Projects
Status: Published/Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants