Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

490 Understand token requirements in communities #555

Closed

Conversation

Fabiomorais87
Copy link
Contributor

Hi @jorge-campo,

In accordance with our agreement, I am sending the PR after we have completed the two steps.

1 - Meet with Jorge to determine if the article provides the user with all the information they need.

2 - Worked with Emma to polish the English.

I would appreciate any suggestions you have. :)

Fabio

@Fabiomorais87 Fabiomorais87 added doc-new Additions to the Status documentation E:Communities Status Communities labels Apr 11, 2023
@Fabiomorais87 Fabiomorais87 self-assigned this Apr 11, 2023
@Fabiomorais87 Fabiomorais87 linked an issue Apr 11, 2023 that may be closed by this pull request
Copy link
Contributor

@jorge-campo jorge-campo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Fabiomorais87 , here is my review:

  • In your second paragraph, remove "Community owners can set up token requirements for their communities. To join a community, you need to meet its token requirements." You've already discussed this information in the previous paragraph; no need to repeat us here. You can move the "join a community" link to the first paragraph as well.
  • Don't pluralize token names: It's "10 SNT" and not "10 SNTs".
  • "... as a requirement to join a community" -> "... as a requirement to join their community."
  • "In that case, you need to have a minimum of 10 SNTs to join that community." -> "In that case, you need to have a minimum of 10 SNT in your [Status Wallet][link-to-the-status-wallet-article] to join that community." It may not be immediately obvious to the user where those tokens should be to validate your eligibility.
  • "There are three kinds of tokens in the Status app: assets, collectibles, and ENS" -> You have an Oxford comma before "and" that you need to remove (as funny as it sounds, Oxford spelling doesn't use Oxford commas).
  • I think we can improve a bit the note admonition:
    • "When you join a private community, the token required to join is not transferred to anyone. They remain on your account. They are simply used for verification purposes, and your tokens remain in your possession."
    • -> "When you join a private community, the token or tokens required to join are not transferred to anyone. They are used for verification purposes only, and they remain in your possession and wallet."
  • "You meet the requirements" -> I believe these titles work better with the "if", "If you meet the token requirements."
  • "You don't meet the token requirements" -> "If you don't meet the token requirements."
  • The "meet requirements" / "don't meet requirements" need screenshots. Please, ask Francesca to create them for you and if it's OK to use them already. This article's readability would increase significantly.
  • In the "You don't meet the token requirements," you don't explain to users how they should fix this condition. You say that they need to have the required tokens, but how? This is the perfect moment for a call to action -> "To buy the required tokens, read [Buy crypto][link-to-emma's-buy-crypto-subsection]."
  • The placeholder article "Tokens, collectibles, and ENS names" has an Oxford comma you don't need.

After these changes, the article is ready to go 🚀

Thanks!

@Fabiomorais87
Copy link
Contributor Author

Due to the fact that the article has already been published, I am closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-new Additions to the Status documentation E:Communities Status Communities
Projects
Status: Published/Done
Development

Successfully merging this pull request may close these issues.

Understand token requirements in communities
2 participants