Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete your wallet #550

Merged
merged 120 commits into from
May 17, 2023
Merged

Delete your wallet #550

merged 120 commits into from
May 17, 2023

Conversation

earakel
Copy link
Contributor

@earakel earakel commented Apr 6, 2023

No description provided.

@earakel earakel added doc-new Additions to the Status documentation E:Wallet Status Wallet labels Apr 6, 2023
@earakel earakel self-assigned this Apr 6, 2023
@earakel earakel requested a review from jorge-campo April 6, 2023 18:40
@earakel earakel linked an issue Apr 6, 2023 that may be closed by this pull request
Copy link
Contributor

@jorge-campo jorge-campo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shamisem !

The content makes easy to undersand the concept. However, it needs an important part of the wallet: accounts.

In Status Wallet, users have one by-default wallet account, but they can create additional ones. A typical use case is not to delete my entire wallet but to delete one or more accounts I don't longer want to use.

We should mention this and adapt the wording to apply to the whole wallet and one or more wallet accounts.

Considering this, change the title from "Delete your wallet" to "Delete your Status Wallet or wallet account". Even when your text applies to any crypto wallet, we want readers to associate our docs with our app.

  • From a visual point of view, the content can be easier to scan if you "break" the text blocks with an admonition. It's a simple trick, but the article looks "easier". In this case, I'd use the "Remember that ..." inside and tip-style admonition, and place the admonition right before "If you no longer ..."
  • After the last sentence, "... and uninstall the app.", mention that the user can always recover the wallet or wallet account as long as they know the recovery phrase. Then, you can link to the article explaining how to import an account.
  • "... send your leftover crypto to some other wallet address." What do you think about this? "... send your leftover crypto to some other account or wallet address."
  • You're missing the status-wallet/index.md entry for this topic.

Fabiomorais87 and others added 27 commits May 12, 2023 11:14
@earakel earakel merged commit 4b6c9ad into develop May 17, 2023
@earakel earakel deleted the 546-delete-your-wallet branch May 17, 2023 08:28
@earakel
Copy link
Contributor Author

earakel commented May 17, 2023

Hey @jorge-campo! Excellent suggestion, thank you - all done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-new Additions to the Status documentation E:Wallet Status Wallet
Projects
Status: Published/Done
Development

Successfully merging this pull request may close these issues.

Delete your wallet
4 participants