-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add Jenkinsfile, requirements.txt and redirect #55
Conversation
230275e
to
3124084
Compare
I'm afraid I can't make all the links work on the Status Help site build. The links only work at the / level on the main index.html file https://github.com/status-im/help.status.im/blob/develop/docs/en/index.md.
I'm not controlling the URLs from within Material config at mkdocs.yml. Note: GitHub Pages is still enabled on this repo, and I think it shouldn't be if we go with our own CI. I have removed them in other repos by setting the config to "none," according to GitHub's help. |
@jorge-campo that has nothing to do with method of deployment and everything to do with the contents of the documents. Look at this file: help.status.im/docs/en/getting-started/index.md Lines 14 to 15 in 3124084
Do you see anything wrong here? Or this one:
Please look at the format of links in Markdown: |
Hey @jakubgs, I'll add here the information we discussed, for the record. We don't use Markdown URLs in the traditional Markdown way:
the
Why are we doing this? Two main reasons:
Managing URLs is hard, and there isn't a perfect solution. But I believe that by centralizing the URLs for each language on its own Notice that this is supported by Material for MkDocs through the Snippets extension, and described in other installations. Notice also that this works as expected CleanShot.2022-04-21.at.10.57.22.mp4This is the reason I think the build is somehow messing with this |
This adds CI builds for both main branches: * `develop` built by [CI job](https://ci.status.im/job/website/job/dev-help.status.im/) to publish to https://dev-help.status.im/ * `master` built by [CI job](https://ci.status.im/job/website/job/help.status.im/) to publish to https://help.status.im/ Changes should be made against `develop` and then once ready `master` should be rebased on `develop` to push the changes to the main site. Related: status-im/infra-misc@305f9445 Resolves: #27 Signed-off-by: Jakub Sokołowski <[email protected]>
3124084
to
ad08364
Compare
For future reference, the issue with the links was their definition. Before it was: [download-status-for-linux]: /help.status.im/getting-started/download-status-for-linux
[download-status-for-mac]: /help.status.im/getting-started/download-status-for-mac
[run-status-app-first-time]: /help.status.im/getting-started/run-status-app-first-time But the correct form is just the path without the domain or the weird prefix slash: [download-status-for-linux]: /en/getting-started/download-status-for-linux
[download-status-for-mac]: /en/getting-started/download-status-for-mac
[run-status-app-first-time]: /en/getting-started/run-status-app-first-time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @jakubgs. Thanks for all the changes and the fixes to the edit_uri
paths.
This adds CI builds for both main branches:
develop
built by CI job to publish to https://dev-help.status.im/master
built by CI job to publish to https://help.status.im/Changes should be made against
develop
and then once readymaster
should be rebased ondevelop
to push the changes to the main site.Related: https://github.com/status-im/infra-misc/commit/305f9445
Resolves: #27